sonyxperiadev / device-sony-yoshino

19 stars 40 forks source link

platform : Add vndservicemanager package to fix bootloop on yoshino devices #166

Closed ShujathMohd closed 3 years ago

ShujathMohd commented 3 years ago

https://github.com/sonyxperiadev/device-sony-common/blob/master/rootdir/vendor/etc/init/hw/init.common.rc#L44

init is failing to start vndservicemanager and throwing the below message :

Command 'start vndservicemanager' action=init (/system/etc/init/hw/init.rc:397) took 0ms and failed: service vndservicemanager not found Command 'start vndservicemanager' action=init (/vendor/etc/init/hw/init.maple.rc:44) took 0ms and failed: service vndservicemanager not found

which is resulting in blank screen after the bootloader message until force shutdown.

This is fixed by adding vndservicemanager package.

Test case : Tested on maple and confirmed its booting.

MarijnS95 commented 3 years ago

@ShujathMohd Can you try commenting out the start line instead, remove vndservicemanager from the build again (make installclean) and see if the device boots as well?

ShujathMohd commented 3 years ago

@ShujathMohd Can you try commenting out the start line instead, remove vndservicemanager from the build again (make installclean) and see if the device boots as well?

Aye aye captain, trying it now.

ShujathMohd commented 3 years ago

@MarijnS95

'ed out the start vndservicemanager in init.common.rc and make installclean.

still same issue, blank screen after the bootloader.

Logs still shows same message

Command 'start vndservicemanager' action=init (/system/etc/init/hw/init.rc:397) took 0ms and failed: service vndservicemanager not found Command 'start vndservicemanager' action=init (/vendor/etc/init/hw/init.maple.rc:44) took 0ms and failed: service vndservicemanager not found

Checked into system/etc/init/hw/init.rc and found below lines

# Start essential services.
start servicemanager
start hwservicemanager
start vndservicemanager
sjllls commented 3 years ago

You need to set PRODUCT_SHIPPING_API_LEVEL := 29 as well if you want to build vndservicemanager on A11.

MarijnS95 commented 3 years ago

@ShujathMohd Interesting, AOSP removes vndservicemanager for API level >=30 but leaves the start in unconditionally; iirc these are not fatal though (it likely doesn't boot when something actually tries to use the service).

Anyway, I've just been pinged that we don't set the API level for ~Yoshino~ Maple (it is set to 26 for Poplar/Lilac) while we do (and have to) for all other platforms; expect a commit shortly that adds it as required. We will probably investigate deprecating and removing vndservicemanager at some later point in time.

@sjllls thanks as well; I assumed it was set to 26 like all the other devices. Surprising it kept working properly for that long, we've been holding off updating the API levels until being absolutely sure everything adheres to the new constraints...

jerpelea commented 3 years ago

fixed by adding PRODUCT_SHIPPING_API_LEVEL := 26

MarijnS95 commented 3 years ago

No, we should set it to 26 like Poplar and Lilac, until we check all the boxes for a higher API level on the vendor side.

MarijnS95 commented 3 years ago

be38467b6cfc0f4804cc7e7c09a3a1be9227d1b8 This was fixed here btw, with API level 26.