sonyxperiadev / device-sony-yoshino

19 stars 40 forks source link

init.yoshino.pwr.rc: remove deprecated configs #169

Closed ShujathMohd closed 3 years ago

ShujathMohd commented 3 years ago

in the 4.14 kernel these configs are deprecated and should be removed to get rid of irrelevant errors in dmesg/logcat.

Applicable to yoshino,nile,ganges and tama

07-22 23:20:05.795 0 0 I init : Command 'write /sys/devices/system/cpu/cpu0/cpufreq/interactive/use_migration_notif 1' action=sys.boot_completed=1 (/vendor/etc/init/init.yoshino.pwr.rc:69) took 0ms and failed: Unable to write to file '/sys/devices/system/cpu/cpu0/cpufreq/interactive/use_migration_notif': open() failed: Permission denied

07-22 23:20:05.800 0 0 I init : Command 'write /sys/devices/system/cpu/cpu0/cpufreq/interactive/max_freq_hysteresis 79000' action=sys.boot_completed=1 (/vendor/etc/init/init.yoshino.pwr.rc:77) took 0ms and failed: Unable to write to file '/sys/devices/system/cpu/cpu0/cpufreq/interactive/max_freq_hysteresis': open() failed: Permission denied

07-22 23:20:05.801 0 0 I init : Command 'write /sys/devices/system/cpu/cpu0/cpufreq/interactive/ignore_hispeed_on_notif 1' action=sys.boot_completed=1 (/vendor/etc/init/init.yoshino.pwr.rc:79) took 0ms and failed: Unable to write to file '/sys/devices/system/cpu/cpu0/cpufreq/interactive/ignore_hispeed_on_notif': open() failed: Permission denied

Haxk20 commented 3 years ago

IDK if this is the proper fix.

Possibly making it possible for the init script to write to those files could be a better solution.

Tho @MarijnS95 probably knows better what could be better.

ShujathMohd commented 3 years ago

IDK if this is the proper fix.

These configs doesnt exist in 4.14 kernel https://github.com/sonyxperiadev/kernel/blob/aosp/LA.UM.7.1.r1/drivers/cpufreq/cpufreq_interactive.c

Haxk20 commented 3 years ago

IDK if this is the proper fix.

These configs doesnt exist in 4.14 kernel https://github.com/sonyxperiadev/kernel/blob/aosp/LA.UM.7.1.r1/drivers/cpufreq/cpufreq_interactive.c

Ah in that case yeah this is OK. Even tho quite weird for it to report permission issue instead of no such file.