search

sonyxperiadev / gerrit-events

MIT License
47 stars 62 forks source link

Add rerun-check event #107

Closed bpedersen2 closed 3 years ago

bpedersen2 commented 3 years ago

The checks plugin for gerrit got a new event rerun-check[1] to signal that a rerun is wanted. Add support for it here.

The support for gerrit-trigger-plugin can be found here: [2]

[1] https://gerrit-review.googlesource.com/c/plugins/checks/+/255373 [2] https://github.com/jenkinsci/gerrit-trigger-plugin/pull/435

davido commented 3 years ago

@rsandell @lucamilanesio

Thanks for the approval. CI failure doesn't seem to be related. Is the CI flaky?

java.security.InvalidKeyException: The security strength of SHA-1 digest algorithm is not sufficient for this key size
    at sun.security.provider.DSA.checkKey(DSA.java:109)
    at sun.security.provider.DSA.engineInitSign(DSA.java:141)
    at java.security.Signature$Delegate.engineInitSign(Signature.java:1329)
    at java.security.Signature.initSign(Signature.java:621)

Could this be merged, so that we could proceed with review/approval of the corresponding Gerrit-Trigger plugin PR: https://github.com/jenkinsci/gerrit-trigger-plugin/pull/435 ?

Thanks!

rsandell commented 3 years ago

Yes the CI is flaky, haven't had time to dig into how to fix it.