search

sonyxperiadev / gerrit-events

MIT License
47 stars 62 forks source link

Add "private" and "wip" states to Change #73

Closed sselberg closed 6 years ago

sselberg commented 6 years ago

Gerrit version 2.15 adds two new attributes to the change, "wip" and "private" that replaces the old "draft" state [1].

[1] https://gerrit-review.googlesource.com/c/gerrit/+/148751

sselberg commented 6 years ago

@hugares

sselberg commented 6 years ago

@rsandell

sselberg commented 6 years ago

The draft-published event is removed in Gerrit 2.15, but I figured that should be done in a different pull request or should I bundle it with this one?

rsandell commented 6 years ago

@sselberg we haven't fully figured out a good deprecation policy in this library yet. If someone uses this lib with something older than Gerrit 2.15 then draft-published would still be around and should be supported imho.

rsandell commented 6 years ago

@sselberg any movement on this? Might soon get merge conflicts...

rsandell commented 6 years ago

81 that replaces this is merged