search

sonyxperiadev / gerrit-events

MIT License
47 stars 62 forks source link

Precursor to allow credentials from Jenkins Credentials #80

Closed MattLud closed 4 years ago

MattLud commented 6 years ago

This work is needed to support passing credentials from Jenkins to the gerrit library.

rsandell commented 6 years ago

You can probably somewhat easy make a for example StringIdentity class and add that via JSch.addIdentity(Identity identity, byte[] passphrase) instead of writing the file to disk.

Look at for example how com.jcraft.jsch.IdentityFile.newInstance is implemented for inspiration.

clabu commented 4 years ago

This is two years old. Is this pull request still needed, or has this use case been solved by some other code change?

rsandell commented 4 years ago

Might still be needed, but PRs can be revived.