search

sonyxperiadev / gerrit-events

MIT License
47 stars 62 forks source link

Cache the existing SSH connection for GerritQueryHandler #86

Closed apetres closed 5 years ago

apetres commented 5 years ago

Recreating the SSH connection for each query may be slow. Let's support keeping one open all the time. My queries are 4 times faster now :D

Plan to use it from jira-gerrit-plugin.

apetres commented 5 years ago

My bad. Javadoc added.

rsandell commented 5 years ago

BTW If this library is used in other Jenkins plugins maybe we should look at making a Gerrit Events plugin so that the library can be better used without risking version compatibility problems? Maybe even put in some common Jenkins code into it that both plugins use?

Just a thought.

apetres commented 5 years ago

Actually jira-gerrit-plugin is a plugin (addon) for Atlassian Jira, not for Jenkins. So IMO keeping it a library is nice because we can leverage its API from multiple apps which query Gerrit.