search

sonyxperiadev / kernel

Other
353 stars 364 forks source link

arm64: dts: somc: kumano: add camera dt support #2495

Closed sraase closed 2 years ago

sraase commented 2 years ago

Add camera device tree support for kumano. Remove the unused sony_camera device nodes.

Do not inherit from QCOM MTP, because our hardware configuration is different anyway. Results in a cleaner, separate camera dt.

Untested, handle with care.

bartcubbins commented 2 years ago

Camera framework will not work until bandwidth voting logic for CPAS is updated Reference: https://github.com/sonyxperiadev/kernel/commit/a56cd66b6755ee0a28228eb68b0af26da90c3f01 https://android.googlesource.com/kernel/msm-extra/devicetree/+/4c66cf9960b9180ec5f42a1e188f49a588f24ba3

sraase commented 2 years ago

I know. This is why this patch is untested. :) Thanks for the reference, this seems to be exactly what I was missing.

bartcubbins commented 2 years ago

Without this you will get a kernel panic, everything else should be fine. I have a similar configuration in my local repository so I can tell that it has already been tested:)

sraase commented 2 years ago

The reference is for kona (edo), but the pull request is for sm8150 (kumano), so it doesn't work. Adding a minimal/empty "camera-bus-nodes" only causes problems down the line. So we need to correctly update sm8150-camera.dtsi, but I can't find any patch to do so.

sraase commented 2 years ago

My knowledge of doing git is apparently insufficient, so I made a new pull request instead. Sigh.

MarijnS95 commented 2 years ago

@sraase the new PR was created from the same branch name, did you - as Github says - delete and recreate the fork?