search

sonyxperiadev / kernel

Other
352 stars 362 forks source link

[7.1.r1] arm64: dts: qcom: sm8150: Correct addresses from 55.2.A.xxx #2586

Closed voidanix closed 10 months ago

voidanix commented 10 months ago

Actually fixes https://github.com/sonyxperiadev/bug_tracker/issues/694

voidanix commented 10 months ago

In case you are wondering, running a stock-based kernel with these updated addresses works just fine with both the A10 and A11 modem firmware, so I expect it to "just werk" here as well.

jerpelea commented 10 months ago

not the best explanation but a valid patch

MarijnS95 commented 10 months ago

The modem subsystem probably needs a bigger memory region (presumably for firmware, PIL = Peripheral Image Loader) but nothing in this patch explains it.

Besides, I'm certain this is not about the addresses anyway. You're increasing the size of the modem PIL memory area, and for that the rest simply has to move out of the way.

jerpelea commented 10 months ago

@MarijnS95 valid explanation ;)

MarijnS95 commented 10 months ago

If only it would have made it into the commit message :smirk::wink::smirk::wink:. Who knows, maaaaaybe future contributions.

voidanix commented 10 months ago

@MarijnS95 yeah, my bad.

The qcom commits regarding this just go "we got new memory mappings lol" without explaining anything: I just went ahead and explained the consequences of not having the DTS updated.

jerpelea commented 10 months ago

@voidanix you will do it in the future ;)

Thaodan commented 7 months ago

The modem subsystem probably needs a bigger memory region (presumably for firmware, PIL = Peripheral Image Loader) but nothing in this patch explains it.

Besides, I'm certain this is not about the addresses anyway. You're increasing the size of the modem PIL memory area, and for that the rest simply has to move out of the way.

I just catched up with this, yeah very late.

Thanks for explaining the change, it does not make sense outright because the context is missing. Issues like these also very easily explain bugs that happened when people flashed the "wrong" stock Android.