sonyxperiadev / pygerrit

MIT License
52 stars 52 forks source link

Allow unicode characters in gerrit commands #24

Closed notnownikki closed 9 years ago

notnownikki commented 9 years ago

Trying to use pygerrit to submit reviews fails if there is a unicode character in the review comment. This change sees if the message is valid ascii, and if it's not, encodes as utf-8.

dpursehouse commented 9 years ago

Thanks for contributing this.

Merged as aa91316c268ecc00eb1217e9d2903cb52b675fe7