FM receiver support - Githubissues

dcaliste commented 2 years ago

Hello, I would like to ask if it would be possible to get the FM receiver to work again ? I found an older repository for it : https://github.com/sonyxperiadev/vendor-broadcom-bt-fm but it seems that it is not available anymore.

May I ask what are the current blockers to get it working ? In case of an open source code, what would be the repository to help contributing to get it working ?

I'm sorry if it's not the repository or place to ask. Please, be kind in that case, to point me to the right channel for this kind of discussion.

dcaliste commented 2 years ago

Thanks a lot for the pointers. I'll read the code you're pointing to and try to understand it. It's a quite different context to what I'm accustomed to, so it may take a while before I come up with something. But I'm already grateful from your guidance. And very thrilled that you didn't reply with a no go for whatever reason. Thanks again.

jerpelea commented 2 years ago

I already started a FM clone for the project and the git should appear soon on github

dcaliste commented 2 years ago

Great news ! I'll try to properly understand the code behind the pointers in the meantime.

jerpelea commented 2 years ago

clone those 3 gits and make them compile first

https://github.com/sonyxperiadev/vendor-qcom-opensource-fm-commonsys https://github.com/sonyxperiadev/vendor-qcom-opensource-system-bt https://github.com/sonyxperiadev/vendor-qcom-opensource-fm-commonsys

dcaliste commented 2 years ago

Thanks, first and last are the same links. Did you mean https://github.com/sonyxperiadev/vendor-qcom-opensource-bluetooth_ext as third repo ?

jerpelea commented 2 years ago

@dcaliste this is the diff for your local_manifest

--- a/qcom.xml
+++ b/qcom.xml
@@ -27,4 +27,9 @@
 <project path="vendor/qcom/opensource/bootctrl" name="vendor-qcom-opensource-bootctrl" groups="device" remote="sony" revision="aosp/LA.UM.9.14.r1" />

 <project path="vendor/qcom/opensource/time-services" name="vendor-qcom-opensource-time-services" groups="device" remote="sony" revision="aosp/LA.UM.9.14.r1" />
+
+<project path="vendor/qcom/opensource/commonsys-intf/bluetooth" name="vendor-qcom-opensource-bluetooth-commonsys-intf" groups="device" remote="sony" revision="aosp/LA.UM.9.12.r1" />
+<project path="vendor/qcom/opensource/commonsys/system/bt" name="vendor-qcom-opensource-system-bt " groups="device" remote="sony" revision="aosp/LA.UM.9.12.r1" />
+<project path="vendor/qcom/opensource/commonsys/fm" name="vendor-qcom-opensource-fm-commonsys" groups="device" remote="sony" revision="aosp/LA.UM.9.12.r1" />
+<project path="vendor/qcom/opensource/commonsys/bluetooth_ext" name="vendor-qcom-opensource-bluetooth_ext" groups="device" remote="sony" revision="aosp/LA.UM.9.12.r1" />
 </manifest>

dcaliste commented 2 years ago

Hello @jerpelea some report of my advance so far:

I've added the four directories to my local manifest (correcting the typo for system/bt one where there is a space in the name raising some error during repo sync procedure). Issuing m vendorimage does not imply compiling any of these directories by default and I'm not accustomed enough with Android build system to understand where to add something to get it added. I tried to add something like
```
PRODUCT_PACKAGES += \
libfm-hci
```
in device/sony/common/common-packages.mk but it didn't help.
So I gather the various library targets in these four directories from the Android.bp files and issued m target_name for each of them separately.
Some targets are compiling out of the box, like libbt-rootcanal_qti, while some others raised issues. Mainly they are of different categories of issues:
- PROPERTY_VALUE_MAX is undefined. After some investigations it appears that in device/sony/seine/bluetooth/bdroid_buildcfg.h, this macro got undefined on line 45 while it was previously defined by an include of <cutils/properties.h>. Then, later on in other targets, including again <cutils/properties.h> brings nothing because it was already included once. I circumvent this issue by moving the various #include "osi/include/properties.h" before the #include "bt_target.h". I don't think it's a good fix, but it helped seeing if everything can compile.
- some of the constants are different in bt_av.h between the file coming within qcom/opensource/commonsys/system/bt and from $ANDROID_ROOT/system/bt. Adding a "vendor/qcom/opensource/commonsys/system/bt/include" in the include dirs in Android.bp help to include the proper file. See for instance system/bt/audio_hal_interface/Android.bp
- some files are using a mix of constants present in vendor/[...]/bt_av.h but also constants from android root version, see audio_hal_interface/a2dp_encoding.cc. I then commented out portion of codes using the constant present only in the android root variant.
- some files requires access headers not publicly available. Missing headers are vendor/qti/hardware/fm/1.0/IFmHci.h for fm_helium, libfm_hci targets, vendor/qti/hardware/btconfigstore/1.0/IBTConfigStore.h for FM2, libqcomfm_jni, libbluetooth_qti, libbtconfigstore targets, com/qualcomm/qti/bluetooth_audio/1.0/IBluetoothAudio.h for libbluetooth_qti, libbtif_qti targets.

I don't know if these reports are of any interest for you. Would you advice me to create PRs on the various repos here for the PROPERTY_VALUE_MAX issues ? Or for the includes ? What about the missing headers ? What can I do ?

dcaliste commented 2 years ago

I succeeded in compiling the above repo applying the mentioned PRs. About my previous message on issues with PROPERTY_VALUE_MAX, they are all gone when compiling the whole tree and not the libraries one by one. The headers are also properly generated with the HAL files added in interface repo.

But that's the really initial first step : I cannot actually test that the HALs, for FM in particular, are correct since I'm not currently running an AOSP device but a SailfishOS one. What do you think about the advances ? Am I going in the right direction ?

sonyxperiadev / vendor-qcom-opensource-bluetooth

FM receiver support #4