Support for seach and thumbnails

holm commented 10 years ago

I needed to extend the client to support search and thumbnails. As I was using the client for the first time I also discovered some inconsistencies in the returned values. Sometimes it was the response object, sometimes the json object. It lead me down a bit of a rabbithole and I ended up moving quite a few things around (and more than once). I am personally fairly happy with the current state of it, but it is probably a bit opinionated.

I should really have made more separate pull requests, but since I was in a hurry to get the changes done for Podio, I wasn't very organized in my changes.

So take it, parts of it, or reject it, it's all up to you :)

tals commented 10 years ago

These are really good! Thank you!

A few things though:

The tests are broken (see test_authentication.py). You can also run these with nosetests
Make sure coverage is still at 100% (nosetests should display it at the bottom) :)

tals commented 10 years ago

Also, refresh() & _request() & CredentialsV2.__init__() are missing documentation :)

Other than that, it's really really nice. Thank you!

holm commented 10 years ago

Sorry about, I should have spent more time on it. It should all pass now and have 100% coverage. I will work on the documentation also.

coveralls commented 10 years ago

Coverage decreased (-0.39%) when pulling 8cf71acee6788f12aadda65a5567f140ad93f87c on holm:master into a7aba3c5a280f6692d2f132d851fcf2fdbd8286d on sookasa:master.

coveralls commented 10 years ago

Coverage remained the same when pulling e2db53674b1d76ec9a098d1c67c194834e50bcce on holm:master into a7aba3c5a280f6692d2f132d851fcf2fdbd8286d on sookasa:master.

coveralls commented 10 years ago

Coverage remained the same when pulling 6daa27a7bb4473c223038f6c7a728655b0fda3e3 on holm:master into a7aba3c5a280f6692d2f132d851fcf2fdbd8286d on sookasa:master.

coveralls commented 10 years ago

Coverage remained the same when pulling 56043e0028d08e06d56210552f89c060b5797255 on holm:master into a7aba3c5a280f6692d2f132d851fcf2fdbd8286d on sookasa:master.

tals commented 10 years ago

:+1: There are a few little things left (flake8 is raising some pep8 warnings, and readme.MD needs updating), but I can take care of those :)

Should I merge, or do you want to add something else? :)

holm commented 10 years ago

I am all done, thanks!

tals commented 10 years ago

You rock :)

tals commented 10 years ago

(I'll do a pypi push after I'll update the docs)

tals commented 10 years ago

Ha, just saw the pep8 patch. Open a new PR? :P

holm commented 10 years ago

Yeah, it's here: https://github.com/sookasa/box.py/pull/3

sookasa / box.py

Support for seach and thumbnails #2