soolar / sl_ascend

An ascension script for kolmafia
11 stars 5 forks source link

[tcrs] Use potions for maximizing, fix occasional failure to unlock Hidden City #252

Closed jaspercb closed 5 years ago

jaspercb commented 5 years ago

Two main changes:

  1. add tcrs_maximize_with_items(), which looks through all your potions and uses any that would help with whatever you're trying to maximize. Is this hacky? Yeah. Is it probably an improvement on not doing this? Also yeah. Currently ambivalent on what the right semantics are with this - should it run on every maximizer call? Should it be separate and be called manually for specific adventures? If so, some maximizer invocations care about minimums (Icy Peak), while some are unbounded (+Sleaze damage for zeppelin protesters). Some open questions, I think this is an improvement on the status quo but am not particularly attached to its current form.

This might be hinting at a future opportunity to replace slMaximize() with a function that takes a set of constraints (minimum of some stats, banisher available, equip such-and-such, try to maximize sleaze damage, can guarantee 10% drop that's YR-able) and finds an optimal equipment setup given those constraints?

  1. Fix issue in Hidden City unlock where if, when searching for Nostril without stone wool, we:
    • Rolled the Hidden Heart encounter
    • Randomized the pokemon in that encounter
    • Rolled Pikachu
    • Continued adventuring and again rolled the Hidden Heart adventure we would not proceed to unlock the hidden city