soolar / sl_ascend

An ascension script for kolmafia
11 stars 5 forks source link

Asdon not used correctly for Rockband flyering #257

Open Phate4569 opened 5 years ago

Phate4569 commented 5 years ago

Another Asdon interaction issue. When it has the quest to flyer for the arena, it persists with Driving Stealthily, rather than stopping and using Driving Recklessly. This is doubly counter-intuitive as it makes you finish the quest much more slowly by spending more turns in non-coms and essentially losing out on +25 monster level.

jaspercb commented 5 years ago

I'm... pretty sure that makes sense if it needs Driving Stealthily for another quest it's currently completing. sl_ascend can't make estimates about how many turns are left in various quests, so we can't really encode complex logic like "if we're on-track to finish flyering before other quests: drive stealthily; else: drive recklessly". So I don't think this is really feasible.

Phate4569 commented 5 years ago

I'd believe that if the script didn't blow 30 turns in Hidden City flyering after closing out that leg of the quest (even with NEP available).

jaspercb commented 5 years ago

The limiting factor is going to depend on the IOTMs and skills that are available to the account - for example, my account powerlevels at a pretty brisk pace and has no issues with running out of thing to flyer. Since accounts vary so widely in IOTMs available and skills, it's tough to predict which way it's going to go - and adding new machinery to make calls like "are we on track to finish flyering?" could make the codebase difficult to maintain.

That said, I agree that using NEP for flyering if we're out of quests to do would help a lot. :)

Phate4569 commented 5 years ago

I do understand that it would be a lot of code to maintain, but the calls are there, or at least there is some code that spawns red messages that say it is not on track.

I dunno. I was paying a lot of attention to Asdon use today because of the other issue I posted about it failing to make and feed bread. The Asdon can be very powerful, and it seems to be used pretty inefficiently in places like the Tavern Basement (+ML gives Rat Kings for tails), Oil Peak (Wastefully if > 25 ML away from next oil tier), Boiler Room (+ML to charge boilers), etc.

Sure, it would cost more money, but it can be adjusted on the fly.