search

soolar / sl_ascend

An ascension script for kolmafia
11 stars 5 forks source link

Add Pirate Realm to relay #267

Closed Phate4569 closed 5 years ago

Phate4569 commented 5 years ago

Edit to add pirate realm to relay.

soolar commented 5 years ago

Can you also run BUILD/assemble.sh? (From in the BUILD directory). If not, I can after I approve the merge, which is fine too.

Phate4569 commented 5 years ago

I can't right now, I'm on mobile.

On Thursday, July 4, 2019, soolar notifications@github.com wrote:

Can you also run BUILD/assemble.sh? (From in the BUILD directory). If not, I can after I approve the merge, which is fine too.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/soolar/sl_ascend/pull/267?email_source=notifications&email_token=AMJETLIYJBX23MY55OJKKSTP5ZCBNA5CNFSM4H5HL6C2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZH7VVQ#issuecomment-508558038, or mute the thread https://github.com/notifications/unsubscribe-auth/AMJETLNHKX77IY3FCIZUWDTP5ZCBNANCNFSM4H5HL6CQ .

jaspercb commented 5 years ago

Don't entries need to be tab-separated? Plus the assemble.sh line. Please test your code.

Phate4569 commented 5 years ago

WTF. Everything I edit on Git's GUI editor gets changed to spaces rather than tab?! See my latest commit where I deleted and reinserted the tabs on frAlways.

I am unfamiliar with github, I only really use my company's internal git.

Phate4569 commented 5 years ago

Please just delete this pull (I am trying to figure out how to do it and failing miserably).

soolar commented 5 years ago

You can't delete a pull request, but you can close it.

soolar commented 5 years ago

I've gone ahead and done this myself since it's a simple fix. Thanks for bringing it to my attention!