soonaverse / soonaverse-dao

The Soonaverse is a decentralized platform for communities, enabling the seamless creation, management, and interoperability of DAOs.
https://www.soonaverse.com
Apache License 2.0
64 stars 8 forks source link

Voting results of proposal showing wrong #1076

Closed ILLUMINATIOTA closed 1 year ago

ILLUMINATIOTA commented 1 year ago

Results show wrong in proposal section

People who didn't vote yet are counted as a 'yes'-vote on our recently started proposals.

https://soonaverse.com/proposal/0x69f45e765e871dd2019e8738901a6d975bcfec35/overview

https://soonaverse.com/proposal/0xf423a25fdc2e479b03ed3a97eb95cc0986767895/overview

adamunchained commented 1 year ago

How so?

  1. Proposal, you have 2 yes/4 no. It shows correctly 40% Yes / 60% No out of total voted.
  2. Proposal, you have 1 yes/4 no. It shows correctly 20% yes / 80 % no out of total voted
adamunchained commented 1 year ago

Feel free to re-open if there is something I’ve missed

ILLUMINATIOTA commented 1 year ago

This is still an issue. It may show correct results if looked deep into proposal but on the proposal page every not yet voted vote counts as first vote option!

ILLUMINATIOTA commented 1 year ago

Screenshot 2023-03-31 182656

ILLUMINATIOTA commented 1 year ago

Screenshot 2023-03-31 182643

humaint commented 1 year ago

SCR-20230404-jpa.png

@adamunchained it looks like a random error on some proposals, like this example

there are casted votes but the graph doesn't reflect them

adamunchained commented 1 year ago

@theflyingrabbit - I thought it was an UI bug but it seems backend is not correctly storing voting statistics:

See Proposal: 0x9b23a13484b99d52fe3b177f2eadde8a4fc9d996

Screenshot 2023-04-11 at 2 46 32 PM
flyingrabbit-lab commented 1 year ago

@adamunchained The proposals reported by ILLUMINATIOTA seem correct to me.

The one reported by humaint is indeed wrong. answers 4:0 should be 4:1. This is an old proposal however, I am assuming that there must have been a temporary bug at some point as I can't find any bug in the code. I have also tested proposals manually via the UI and it seems to be working properly.

adamunchained commented 1 year ago

closing as this was an issue with old proposals.

@ILLUMINATIOTA - do you have this issue with new proposals?