search

soonaverse / soonaverse-dao

The Soonaverse is a decentralized platform for communities, enabling the seamless creation, management, and interoperability of DAOs.
https://www.soonaverse.com
Apache License 2.0
64 stars 8 forks source link

Token description is not editable #1088

Closed epochzro closed 1 year ago

epochzro commented 1 year ago

Editing the token info returns an error

To Reproduce Steps to reproduce the behavior:

  1. goto the token page
  2. Click on 'Edit token info'
  3. Click 'Save Changes'
  4. See error "Token in invalid status."

Expected behavior The updated text is saved

adamunchained commented 1 year ago

@theflyingrabbit - tokens should be editable in any status.

Let's change: assertTokenStatus(token, [TokenStatus.AVAILABLE]);

flyingrabbit-lab commented 1 year ago

@adamunchained These are the editable fields image.png Should we allow editing these even after the token is minted?

adamunchained commented 1 year ago

@adamunchained These are the editable fields image.png Should we allow editing these even after the token is minted?

Everything except values that are immutable on tangle should be editable (ie. name)

humaint commented 1 year ago

@adamunchained I'm trying to edit availabla token and getting ""Invalid params [{\"message\":\"\\"name\\" is not allowed\",\"path\":[\"name\"],\"type\":\"object.unknown\",\"context\":{\"child\":\"name\",\"label\":\"name\",\"value\":\"Pokemon\",\"key\":\"name\"}}]""

adamunchained commented 1 year ago

@humaint - fixed