search

soopercool101 / BrawlCrate

BrawlBox/BrawlTools Fork, Wii File Editor
https://discord.gg/s7c8763
GNU Lesser General Public License v3.0
148 stars 38 forks source link

When making all files external, don't add a leading '/' #20

Closed kitlith closed 3 years ago

kitlith commented 3 years ago

Previously this produced external paths like the following: /RSEQ/[171] RP_SSN_SE_CLIPMENU_GROUP.brseq Instead, it should produce paths like this: RSEQ/[171] RP_SSN_SE_CLIPMENU_GROUP.brseq which matches external files already found in brsars such as stream/Clp_Menu_BGM01_lr.n.32.brstm

I'd like to note that I haven't tested this yet, as I don't have a convenient setup for brawlcrate dev atm, so that's why it's a marked as a draft PR.

soopercool101 commented 3 years ago

This breaks current BRSAR implementation. Left is a properly opened BRSAR, right is this PR image

soopercool101 commented 3 years ago

I generally recommend against making PRs that you cannot personally test, however, if you push to this branch you can get the automatic builds from https://ci.appveyor.com/project/soopercool101/brawlcrate-pr for your own testing

kitlith commented 3 years ago

hm. how does the current implementation interact with the external files already found in some games?

soopercool101 commented 3 years ago

It attempts to populate external files as if they were found internally

kitlith commented 3 years ago

i did get someone else to test, but the results were inconclusive, maybe partially because I can't get any consistent information on what's breaking. i guess it comes back to me needing to test it myself

soopercool101 commented 3 years ago

Fixed by 3d5c114