search

soopercool101 / BrawlCrate

BrawlBox/BrawlTools Fork, Wii File Editor
https://discord.gg/s7c8763
GNU Lesser General Public License v3.0
148 stars 38 forks source link

png palette import fix #36

Open MichaelHinrichs opened 2 years ago

MichaelHinrichs commented 2 years ago

This is an attempt to consolidate some commits that were left behind in BrawlBox, with changes that have been made to BrawlCrate since it branched off. These changes are based off of libertyernie/png-palette-import-fix, which was branched and merged with the BrawlBox's master branch after BrawlCrate.

The Brawlbox commits read If PngBitmapDecoder can't load a PNG, give up on importing palette and fall back to loading at a higher level.

Adjust for DPI when importing indexed PNG.

Merge pull request #232 from libertyernie/png-palette-import-fix PNG import fixes

soopercool101 commented 2 years ago

What precisely does this fix? Crate already had fixes in place for the DPI and at least one bug with PNG palettes. I didn't merge in the code when it was pushed to Box initially due to some bugs I found when testing it (though it was long enough ago that these may have been fixed and I don't recall what they were)