soopercool101 / BrawlCrate

BrawlBox/BrawlTools Fork, Wii File Editor
https://discord.gg/s7c8763
GNU Lesser General Public License v3.0
148 stars 38 forks source link

Can't convert wav file to BRSTM without having to shorten it because windows forms is not happy with a big number. #51

Open shahoob opened 1 year ago

shahoob commented 1 year ago

Describe the bug Windows Forms is not happy with 6154520.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'File'
  2. Hover on 'New'
  3. Click on 'BRSTM Audio Stream'
  4. Open Rainbow Road (Restored) - Super Mario Kart.wav downloaded from here
  5. See error

Expected behavior Successfully load the file and let the user to their thing. See attached screenshot

Screenshots image

Desktop (please complete the following information):

Crash Log

Value of '6154520' is not valid for 'Value'. 'Value' should be between 'Minimum' and 'Maximum'.
Parameter name: Value 
   at System.Windows.Forms.NumericUpDown.set_Value(Decimal value)
   at BrawlLib.Internal.Windows.Forms.BrstmConverterDialog.LoadAudio(String path)
   at BrawlLib.Internal.Windows.Forms.BrstmConverterDialog.OnShown(EventArgs e)
   at System.Windows.Forms.Form.CallShownEvent()
   at System.Windows.Forms.Control.InvokeMarshaledCallbackDo(ThreadMethodEntry tme)
   at System.Windows.Forms.Control.InvokeMarshaledCallbackHelper(Object obj)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Windows.Forms.Control.InvokeMarshaledCallback(ThreadMethodEntry tme)
   at System.Windows.Forms.Control.InvokeMarshaledCallbacks()

Additional context Workaround: Shorten the song enough.

and listen to this masterpiece also the file in the screenshot is also a masterpiece listen to it