soopercool101 / BrawlCrate

BrawlBox/BrawlTools Fork, Wii File Editor
https://discord.gg/s7c8763
GNU Lesser General Public License v3.0
150 stars 39 forks source link

U8 Archive folder structure is occasionally saved incorrectly #58

Closed Gabriela-Orzechowska closed 1 year ago

Gabriela-Orzechowska commented 1 year ago

Describe the bug U8 Archive folder structure is occasionally saved incorrectly, which causes crashes in the games.

Screenshots Example: Archive's folder structure of MKWii track got completely destroyed (First file, the second shows how the folders should look like) image

However the archive looks "correctly" in BrawlCrate itself after saving. This causes a lot of issues mainly among MKWii creators.

(Additional report) .brasd files do not get names from string pool correctly

soopercool101 commented 1 year ago

Any chance you (or the rest of the MKWii community) would know of a consistent way to reproduce? Or does it seem purely random?

Gabriela-Orzechowska commented 1 year ago

From my today's testing it appears that the issue happens whenever there is more than one nonempty folder in the same location.

soopercool101 commented 1 year ago

As a followup question, does this only happen with BRASD? I couldn't reproduce on my limited tests but didn't try anything with that filetype in particular

Gabriela-Orzechowska commented 1 year ago

Invalid folder structure can happen even without any files inside, just nonempty folders. Like I mentioned, in Brawlcrate it appears normally, however the game/tools like Wiimm's SZS Tools show that it is in fact incorrect. I should have reported brasd stuff as separate issue, my bad.

soopercool101 commented 1 year ago

Could you send a before/after of files saved in such a corrupting fashion? I don't have the time to reproduce at this exact second but I did check with wszst on my earlier tests and was still unable to find anything with the archives I did check

Gabriela-Orzechowska commented 1 year ago

files.zip Here, in the corrupted one I just moved the folders back and forth and saved. From what im seeing, it's just parent index that is wrong

soopercool101 commented 1 year ago

Closed as part of #64