search

sooxt98 / google_nav_bar

A modern google style nav bar for flutter.
MIT License
749 stars 114 forks source link

Feature request: Tooltip or Semantic Label #34

Closed tsinis closed 3 years ago

tsinis commented 3 years ago

Hey @sooxt98!

Writing to you again! Thank you for the great package, but could you add some semantics? Because at the moment GButton doesn't allow us to add any tooltip or semantic tag, so Accessibility Checker or any other semantic analysis SW will not recognize the meaning of this button... Semantics are articularly helpful for people with visual impairments but are also great for testing. A Tooltip would be perfect, but the semanticLabel property should be okay too.

Thanks!

tsinis commented 3 years ago

I can make PR probably, if you accept. Thanks.

sooxt98 commented 3 years ago

Hi @tsinis why don't just simply wrap Gbutton with tooltips or semantics?

tsinis commented 3 years ago

Hi @tsinis why don't just simply wrap Gbutton with tooltips or semantics?

Hey! Because GNav "tabs" parameter only accept List<GButton> not List<Widget>. Thanks for reply.

constructor

sooxt98 commented 3 years ago

@tsinis ah so adding one more Tooltip to GButton would be enough? btw, PR is welcome :3

tsinis commented 3 years ago

@tsinis ah so adding one more Tooltip to GButton would be enough? btw, PR is welcome :3

Ok super. I'll try to push a PR in few days so you can review it. Thanks!

tsinis commented 3 years ago

Thanks for PR merge @sooxt98 ! Wish you good luck with null-safety, stay strong :D