search

sooxt98 / google_nav_bar

A modern google style nav bar for flutter.
MIT License
735 stars 114 forks source link

Compatibility issues after null safety migration #51

Closed sooxt98 closed 3 years ago

sooxt98 commented 3 years ago

@Ascenio Did you know why it's not compatible with Flutter 1.22.6? image

Ascenio commented 3 years ago

It's because as from version 5 and latter the minimum SDK is 2.12.0, which is required to support null safety. But, because of that, version 1.22.6 doesn't meet the minimum SDK. It isn't that big of a deal, it just means that anyone which intends to use version 5+ will need flutter's 2.0+. Anyone which is not in 2.0 yet can still use version 4.0.2.

sooxt98 commented 3 years ago

@Ascenio it is because I saw alot of nullsafty package still supporting older version. I think maybe we just tweak down the min requirement ?

Ascenio commented 3 years ago

Not sure about that. The ones I see compatible with both flutter's 2.0 and 1.22.6 are versions which aren't null safe. A example would be GetX, the version compatible with both is not the null safe version.

sooxt98 commented 3 years ago

@Ascenio check this out https://pub.green/packages/bottom_navy_bar

Ascenio commented 3 years ago

This package is only compatible with all versions because it has not migrated to null safety. The version you see there is 5.6.0, which has sdk: ">=2.2.2 <3.0.0".

Ascenio commented 3 years ago

Actually they have a null safety version, but the one you see at pub.green is not the safe version.

sooxt98 commented 3 years ago

@Ascenio hah I see, they hide it in pre-release