$password parameter should be of type Sensitive[String]

sooyean-hoo / puppetlabs-servicenow_cmdb_integration

Other

1 stars 0 forks source link

$password parameter should be of type Sensitive[String] #4

Open sooyean-hoo opened 1 month ago

sooyean-hoo commented 1 month ago

Describe the Bug

The password parameter for the class is currently of type String. This exposes the password in run logs, Impact Analysis and the catalog.

Expected Behavior

Change the type of this parameter to Sensitive[String] and ensure correct & secure handling of the content. For example. the .unwrap method should only be used inside the epp template.

sooyean-hoo commented 1 month ago

ref https://github.com/puppetlabs/puppetlabs-servicenow_cmdb_integration/issues/35