search

sooyean-hoo / puppetlabs-servicenow_cmdb_integration

Other
1 stars 0 forks source link

Allow use of https:// or http:// and trailing slash in instance parameter #6

Open sooyean-hoo opened 6 months ago

sooyean-hoo commented 6 months ago

Allow passing common variations of the ServiceNow instance to the instance parameter. i.e. https://dev107333.service-now.com/ as well as dev107333.service-now.com.
Currently if you pass the full URL (with https://) you wil get the below error;

Execution of '/tmp/validate_settings.rb /etc/puppetlabs/puppet/servicenow_cmdb.yaml20210708-28674-9vosud' returned 1: /opt/puppetlabs/puppet/lib/ruby/2.7.0/net/http.rb:960:in `initialize': Failed to open TCP connection to https:443 (getaddrinfo: Name or service not known) (SocketError)
sooyean-hoo commented 6 months ago

ref https://github.com/puppetlabs/puppetlabs-servicenow_cmdb_integration/issues/61