search

sooyitao / pe

0 stars 0 forks source link

Misleading error message when adding student with existing register number #2

Open sooyitao opened 1 week ago

sooyitao commented 1 week ago

When adding a student with existing register number the error message says that "This person already exists in the address book". This is misleading as the student is not in the address book but has the same register number as another student

Steps to reproduce

  1. Add a student with any register
  2. Add another student with the same register

Expected outcome

Error message stating that there is another student with the same register

Actual outcome

Error message stating that This person already exists in the address book

image.png

nus-se-script commented 1 week ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Add command (Attempt to add a person being denied)

Description

When attempting to add a contact, I get the error message "Person already exists in the address book", even though, there is no person named "Alvin"

image.png

Steps to reproduce

  1. Add "John Doe" which is the example given when given by the application an invalid add command

  2. Copy the command and change the name to Alvin (Error is shown even if you change all the fields)

[original: nus-cs2103-AY2425S1/pe-interim#1138] [original labels: severity.High type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Justification for low: In actual scenario, unlikely that you will have students that have the same phone number or same email, or same class and register number.

Justification for feature flaw: According to guidelines, the error message provided is correct, however, we do admit that there could be more specifics provided regarding the error.

Justification for not in scope: The work done to the implement the feature for duplicate checking was more important than fixing this minor bug. Moreover, the system fails gracefully. (i.e. the system does not crash) However, we do acknowledge that the error message could be improved in future iterations to provide specifics as to why the provided student input is a duplicate.

image.png

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]