search

sooyitao / pe

0 stars 0 forks source link

Sort name is sorted by all the capital first then small letters #8

Open sooyitao opened 1 week ago

sooyitao commented 1 week ago

When sort name is used, all the names with capital first letter will be at the start while those with small letter first names are at the back no matter the alphabetical order. This cause inconvenience as we would expect the list to be sorted in alphabetical order no matter the capitalisation.

Steps to reproduce

  1. Add a student with a capital letter name at the front (e.g. Alex)
  2. Add a student with a small letter name at the front (e.g. a)

Expected outcome

Sort name should sort by alphabetical order and both student should be near each other

Actual outcome

The students are separated due to the capitalisation.

image.png

nus-se-script commented 1 week ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Sort Command (Sorting by name should follow a different order)

Description When sorting the list by name, although it is stated in the user guide that they are lexicographically sorted in increasing order. This order might not be the best as names may be input without capitalization and when the user sorts by name they might not find the person they want as they are at the bottom of the list

image.png

Suggestion If sorting by name, you could convert them to all lowercase, to have the ordering not affected by capitalisation

[original: nus-cs2103-AY2425S1/pe-interim#1140] [original labels: type.FeatureFlaw severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Justification for not in scope: According to the guidelines, the work done to the implement the feature for sort command was more important than fixing this minor bug. This was clearly stated in the UG that the sorting will be done lexicographically. Moreover, this does not affect the functionality of the feature, it only provides a slight inconvenience (i.e. the system does not crash). However, we do acknowledge that this could be a future improvement.

image.png

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]