sopel-irc / sopel-extras

Broken Sopel modules you might pick up and fix if you want them. Probably faster to just rewrite, though
40 stars 57 forks source link

avoid helpbot crash if misconfigured #56

Closed anarcat closed 9 years ago

anarcat commented 9 years ago

without this patch, if the helpbot channel would be set to None, it would fail with:

AttributeError: 'NoneType' object has no attribute 'lower' (file /usr/lib/python2.7/dist-packages/willie/tools.py, line 362, in _lower)

the modules in -extras should be enabled by default so this makes "None" a valid value that makes the module be ignored. we also default to None so that, by default, the helpbot module doesn't do anything

tyrope commented 9 years ago

This would fix it, if you didn't put None in quotes (which makes it a valid string)

anarcat commented 9 years ago

better?

anarcat commented 9 years ago

thanks