search

sopel-irc / sopel-github

GitHub plugin for Sopel
Other
3 stars 13 forks source link

Regex Failure #132

Open ghost opened 10 months ago

ghost commented 10 months ago

Current regex doesn't match https://github.com/gnomon-/furby-source

dgw commented 10 months ago

Blame the source of the username regex, which has an issue about this problem: shinnn/github-username-regex#4

It seems the username rules about trailing hyphens changed at some point, but GH allowed existing accounts to keep them.

(If you want to throw more fun into the FOSS world, one of the test cases in GrantBirki/github-username-regex-js's readme is a trailing hyphen that's expected not to be valid 🙃)