sopel-irc / sopel-github

GitHub plugin for Sopel
Other
3 stars 13 forks source link

Additional issue/PR event link handling #28

Open half-duplex opened 5 years ago

half-duplex commented 5 years ago

Re: IRC discussion The utility of issue display can be improved by parsing the "hash" part of URLs and displaying the linked comment instead of only the original issue/PR description.

Current:

<+dgw> Edited to add: "Meh." :P https://github.com/sopel-irc/sopel-github/pull/26#pullrequestreview-226279842                    
< Sopel> [GitHub] [sopel-irc/sopel-github #26] HumorBaby: webhook: restrict incoming requests | A bad actor can use this [snip multi-line description]

An improvement would be something like:

< Sopel> [GitHub] [sopel-irc/sopel-github #26] HumorBaby: webhook: restrict incoming requests | dgw comments: Let's call it ready. Maybe this will go into 0.2.0 after all! haha
dgw commented 5 years ago

Thanks for opening this!

Let's collect known document fragment types and what they map to (for API calls):

Once we figure out what to handle, the list above can be made into a task list in the issue OP.

Are there other timeline events that would be worth parsing permalinks for? Force-pushes? Review requests? Assignments? Milestone changes? Labels? References to other PRs/issues? (Many of them just use a generic #event-<ID> fragment format, where the ID maps to this API call.)

dgw commented 3 years ago

I feel bad about punting this again, but I'd really like to get 0.4.0 out in the next week-ish and it would take longer than that to get everything here squared away.