search

sopel-irc / sopel-github

GitHub plugin for Sopel
Other
3 stars 13 forks source link

Can't load on new Sopel setup #56

Closed GideonWolfe closed 4 years ago

GideonWolfe commented 4 years ago

Not sure if I'm doing something wrong, but I'm running sopel in docker. I added this package to the list to automatically download, which it does.

Then in a buffer with sopel I run .load github and I am presented with 

SyntaxError: invalid syntax (file "/home/sopel/.local/bin/python3.6/site-packages/sopel_modules/github/webhook.py, line 167)

I'm not doing anything with webhooks, would just like to query the occasional repo...

dgw commented 4 years ago

That doesn't make sense. Line 167 is bog-standard Python, syntactically equivalent to the line above it. https://github.com/sopel-irc/sopel-github/blob/08a816af92f52793349a07c99af3b941eac4dfb8/sopel_modules/github/webhook.py#L167

@HumorBaby Any insights, given this is happening with Docker?

@GideonWolfe What version of the Sopel Docker image are you using, and what version of sopel-github is it loading?

dgw commented 4 years ago

Ack, it was the line above that. Should be fixed by 23a3a283010a8244d9b37c343e24145ea58ee952 / 0.2.6 (publishing momentarily). Git blame points to #51 as the spot where this syntax error slipped through code review.

dgw commented 4 years ago

Verified that the latest release (0.2.6) loads without errors on the "official" Sopel instance in our freenode channel. If this issue is not actually resolved, feel free to reopen with further details!

GideonWolfe commented 4 years ago

Works great now, thanks for the quick fix!

dgw commented 4 years ago

Thank you for letting me know there was a problem!