search

sopel-irc / sopel-github

GitHub plugin for Sopel
Other
3 stars 13 forks source link

github: include issue/PR state in `issue_info()` #87

Closed dgw closed 3 years ago

dgw commented 3 years ago

Fetches the Pull endpoint if the referenced issue is a pull request AND ALSO has the 'closed' state, to check if it was merged.

Closes #86.

Example:

<Old> [GitHub] [sopel-irc/sopel #2020] half-duplex: logging: don't crash if backend is uninitialized | When
      `core.logging_channel` is used, errors early in startup cause an exception that halts the bot.
      (bdc10e0, current master) […]
<New> [GitHub] [sopel-irc/sopel #2020] merged PR by half-duplex: logging: don't crash if backend is
      uninitialized | When `core.logging_channel` is used, errors early in startup cause an exception that
      halts the bot. (bdc10e0, current master) […]

@half-duplex I like this style better than adding more brackets. What say you?

half-duplex commented 3 years ago

No strong preference on sentence vs brackets, main goal is just having the info there. Thank you!