search

sopel-irc / sopel-imdb

A working re-implementation of the imdb module for Sopel
MIT License
3 stars 2 forks source link

"Incorrect IMDb ID." #14

Open ghost opened 2 years ago

ghost commented 2 years ago 
18:25:31 <Chex> https://www.imdb.com/title/tt19757508/?ref_=nv_sr_srsg_0
18:25:32 <Sackbot> [Error] Incorrect IMDb ID.

oh no

half-duplex commented 2 years ago

Works for me, using either 1.2.2 or master.

< mal> https://www.imdb.com/title/tt19757508/?ref_=nv_sr_srsg_0
< Sopel> [url] Meltdown: Three Mile Island (TV Mini Series 2022) - IMDb | www.imdb.com
ghost commented 2 years ago

@half-duplex that's the url plugin tho, not sopel-imdb

ghost commented 2 years ago

We determined the issue is with omdb, so ¯\_(ツ)_/¯

half-duplex commented 2 years ago

Oop, you're right, I didn't notice the plugin requires an apikey.

ghost commented 2 years ago

FWIW, I'm thinking it might be OMDB's scrapers died again or something. Seems to only happen to TMDB IDs past a certain integer. Haven't found the cut-off yet. :P

https://www.imdb.com/title/tt19883638/ will also fail, for example.

21:35:36 <~xnaas> https://www.imdb.com/title/tt19883638/
21:35:36 <Sackbot> [Error] Incorrect IMDb ID.

So that's the older tt19757508 and the newer tt19883638.

ghost commented 2 years ago

Once I went back to ~tt19500000, the error from omdb changed to Error getting data. 😅

RustyBower commented 2 years ago

We can reopen this. I'll build some better error handling to help the user understand why the IMDB stuff isn't working