search

sopel-irc / sopel-iplookup

IP lookup plugin for Sopel IRC bots
Other
0 stars 0 forks source link

plugin, config: add optional `maxmind_license_key` setting #4

Closed dgw closed 4 months ago

dgw commented 6 months ago

As we have done with other plugins that ship with a built-in API key of some kind (e.g. sopel-reddit), it's always preferable to include the ability to override that built-in key before it's actually needed, lest a key revocation break all installed plugin copies until an emergency release can be published with configuration support.

I'm aware that there are some flake8 errors in this code as it currently exists (maybe @SnoopJ uses a custom user/global config with a non-default line length?) but have reserved fixing those for a separate PR if necessary.

dgw commented 4 months ago

(but clearly we've gotten away with it so far…)

I was surprised the PM who stopped by #3 didn't say anything. But I was already thinking it; just didn't mention in public.

5 eliminates the default key entirely, btw :)