search

sopel-irc / sopel-remind

Other
0 stars 1 forks source link

Reminder should preserve STATUSMSG prefix #10

Open dgw opened 7 months ago

dgw commented 7 months ago

Saving the trigger.sender alone doesn't preserve the status prefix of the reminder command, as of sopel-irc/sopel#2370 (forthcoming 8.0). Simply put, if a reminder is set via PRIVMSG +#channel :.in 1h only voices know about this, the reminder in 1 hour is sent as PRIVMSG #channel :initiator: only voices know about this (I'm simplifying the protocol bits, obviously).

This is surprising, and probably not in a good way. It's the same reason we wanted sopel-irc/sopel#2441, to make it so that responses to commands (or triggers in general) aren't visible to more users than could see the command/trigger itself.

half-duplex commented 2 months ago

Could this be hotfixed by just having the plugin prepend the status_prefix itself when setting a reminder?

dgw commented 2 months ago

Most likely.

Exirel commented 2 months ago

Most likely yes, there is no need to manage more than that I think?