Errors for `/i/` links are back

sopel-irc / sopel-twitter

A Twitter plugin for Sopel

Other

2 stars 5 forks source link

Errors for `/i/` links are back #32

Closed ghost closed 2 years ago

ghost commented 2 years ago

<xnaas> https://twitter.com/i/web/status/1521967479802798083
<+Sopel> Twitter returned an error: User not found.
<+Sopel> [Twitter] Taylor Ogan (@TaylorOgan): Another collision while on Tesla FSD Beta. https://video.twimg.com/ext_tw_video/1521910678096953344/pu/vid/1280x720/xruxYMpb1v-UOQVV.mp4?tag=12 | 20 RTs | 130 ♥s | Posted: 2022-05-04 16:38

dgw commented 2 years ago

Upon quick inspection, appears to be a regression introduced by #28.

dgw commented 2 years ago

Going to leave this for when I (or whoever) wants to make a test suite, because I'm tired of always forgetting to check one or another kind of link(s) in Regex101 before implementing changes.

@half-duplex kindly pointed out that the original, unsimplified implementation of #28 didn't have this problem, so that's a decent starting point.