sopel-irc / sopel-twitter

A Twitter plugin for Sopel
Other
2 stars 5 forks source link

No truncation indicator on super-long tweets #58

Closed dgw closed 6 months ago

dgw commented 1 year ago

The code here:

https://github.com/sopel-irc/sopel-twitter/blob/4ab101aca9632b974bf5363ab4ae8f71bbb1ebae/sopel_twitter/__init__.py#L255-L269

doesn't pass truncation to bot.say() like the similar method call in user-profile handling does:

https://github.com/sopel-irc/sopel-twitter/blob/4ab101aca9632b974bf5363ab4ae8f71bbb1ebae/sopel_twitter/__init__.py#L342

This can even be a problem for tweets that are within the normal character limit, but contain super-long URLs.

One example is this tweet with a Bloomberg URL at the end: https://twitter.com/jasonschreier/status/1707412086651842669 (the expanded Bloomberg article link includes a very long access token, and is therefore silently dropped from the output by Sopel's default safe-length behavior)

dgw commented 6 months ago

Resolved by #61