sopel-irc / sopel

:robot::speech_balloon: An easy-to-use and highly extensible IRC Bot framework. Formerly Willie.
https://sopel.chat
Other
950 stars 405 forks source link

remind: remove plugin reimplemented as external package w/better tests #2478

Closed dgw closed 1 year ago

dgw commented 1 year ago

Description

Tin. Development moved to https://github.com/sopel-irc/sopel-remind, with more comprehensive tests and support for running the plugin on Python 3.11+.(built-in has a regex pattern error).

Starting as a draft because of impending merge conflict from #2471 and waiting for a migration path for existing reminders to the new plugin (see sopel-irc/sopel-remind#1).

Checklist

Exirel commented 1 year ago

Sopel Remind is now available as a package version 0.1.0!

dgw commented 1 year ago

Just need sopel-irc/sopel-remind#5 to be released and we're set to ship this. I take full responsibility for it not being merged yet, because I'm still making suggestions over there to this day. 😅

(I probably should've left remind alone in those recent mypy-cleanup branches to avoid this merge conflict, but it'll be fine.)

dgw commented 1 year ago

Migration feature is released upstream! Time to ready this.

Exirel commented 1 year ago

And it's done! sopel-remind 0.2.0 is up and allows bot's owner to migrate from the built-in plugin.