[x] I can and do license this contribution under the EFLv2
[x] No issues are reported by make qa (runs make lint and make test)
[x] I have tested the functionality of the things this change touches
The corresponding (new) test case test/test_coretasks.py::test_handle_isupport_bot_mode[None] initially failed with an exception traceback, as described in #2509.
With the patch applied, it passes.
Notes
Fun facts about this bug:
It was introduced in #2448 (my fault).
I considered giving core.modes a default='', but it could still become None if someone puts modes = into their config file. The logic changes here would still be required to handle that case, so I decided that None was still a more semantic "not set" value than empty-string and left it without a default value.
Description
Tin. Also added
Noneto tested cases, so if it goes back to throwing an error after future changes we'll find out about it.Checklist
make qa(runsmake lintandmake test)test/test_coretasks.py::test_handle_isupport_bot_mode[None]initially failed with an exception traceback, as described in #2509. With the patch applied, it passes.Notes
Fun facts about this bug:
core.modesadefault='', but it could still becomeNoneif someone putsmodes =into their config file. The logic changes here would still be required to handle that case, so I decided thatNonewas still a more semantic "not set" value than empty-string and left it without a default value.