sopel-irc / sopel

:robot::speech_balloon: An easy-to-use and highly extensible IRC Bot framework. Formerly Willie.
https://sopel.chat
Other
950 stars 405 forks source link

xkcd: address py/mixed-returns CodeQL alert #2511

Closed dgw closed 9 months ago

dgw commented 9 months ago

Description

I started this branch intending to fixup several other alerts, but realized that most of them were of the same type we already decided to dismiss (no one really cares about the return value of a plugin callable).

However, xkcd has a real function that was flagged by this rule, so I chose to still fix it even though it means opening a dinky +1 pull request. But I won't bother milestoning this until it's merged, so it doesn't affect our release timelines in any way.

Checklist