sopel-irc / sopel

:robot::speech_balloon: An easy-to-use and highly extensible IRC Bot framework. Formerly Willie.
https://sopel.chat
Other
951 stars 405 forks source link

ip: remove plugin extracted to external package #2523

Closed SnoopJ closed 8 months ago

SnoopJ commented 8 months ago

Description

This PR removes the built-in ip plugin in favor of the newly packageized sopel-iplookup plugin, as part of #1291. Note that since #2504 hasn't landed yet, I'm still using the older modules terminology here, but if that PR lands first, this one should be reworked to use the new terminology.

~This should not be merged until sopel-iplookup has been uploaded to PyPI.~ Edit: YOLO merge whenever I guess

I have marked this as a breaking change because, per discussion on IRC, we decided that it makes sense for the new package to name the plugin iplookup rather than the more generic ip. If users mention ip in their bot configuration (i.e. to exclude it), they will need to change the name to account for that.

Checklist

dgw commented 8 months ago

We've published sopel-iplookup 1.0.0. I had a soft-block on this being merged before publication, despite @SnoopJ's "YOLO" above, but the plugin's up now so :shipit:

SnoopJ commented 8 months ago

Glad we didn't merge yet, we'd missed that this PR didn't drop the geoip2 requirement! With that change added in bd1e6f1, the path to #2516 should be unblocked, as the breakage caused by the upstream troubles in aiohttp will be quarantined to the third-party package.

dgw commented 8 months ago

I'd ideally like the removal to be a single operation, deleting the plugin and its requirement in one go. I'd also like the Coveralls check statuses to report properly… They're getting stuck on Pending a lot lately and it always seems to be on commits that don't touch any code. 🤔

SnoopJ commented 8 months ago

I'd ideally like the removal to be a single operation, deleting the plugin and its requirement in one go.

Rebased, should be the case now.

I'd also like the Coveralls check statuses to report properly

Yea, dunno what's going on with them :shrug: