Closed SnoopJ closed 8 months ago
We've published sopel-iplookup 1.0.0. I had a soft-block on this being merged before publication, despite @SnoopJ's "YOLO" above, but the plugin's up now so :shipit:
Glad we didn't merge yet, we'd missed that this PR didn't drop the geoip2
requirement! With that change added in bd1e6f1, the path to #2516 should be unblocked, as the breakage caused by the upstream troubles in aiohttp
will be quarantined to the third-party package.
I'd ideally like the removal to be a single operation, deleting the plugin and its requirement in one go. I'd also like the Coveralls check statuses to report properly… They're getting stuck on Pending a lot lately and it always seems to be on commits that don't touch any code. 🤔
I'd ideally like the removal to be a single operation, deleting the plugin and its requirement in one go.
Rebased, should be the case now.
I'd also like the Coveralls check statuses to report properly
Yea, dunno what's going on with them :shrug:
Description
This PR removes the built-in
ip
plugin in favor of the newly packageizedsopel-iplookup
plugin, as part of #1291. Note that since #2504 hasn't landed yet, I'm still using the oldermodules
terminology here, but if that PR lands first, this one should be reworked to use the new terminology.~This should not be merged until
sopel-iplookup
has been uploaded to PyPI.~ Edit: YOLO merge whenever I guessI have marked this as a breaking change because, per discussion on IRC, we decided that it makes sense for the new package to name the plugin
iplookup
rather than the more genericip
. If users mentionip
in their bot configuration (i.e. to exclude it), they will need to change the name to account for that.Checklist
make qa
(runsmake lint
andmake test
)