Closed dgw closed 8 months ago
Before (last CodeQL analysis on master
):
CodeQL scanned 124 out of 124 Python files in this job. Typically CodeQL is configured to analyze a single CodeQL language per job, so check the status page for overall coverage information across all jobs: https://github.com/sopel-irc/sopel/security/code-scanning/tools/CodeQL/status/
Analysis produced the following metric data:
| Metric | Value |
+--------------------------------------------+--------+
| Total lines of Python code in the database | 171510 |
After (with this configuration change):
CodeQL scanned 82 out of 82 Python files in this job. Typically CodeQL is configured to analyze a single CodeQL language per job, so check the status page for overall coverage information across all jobs: https://github.com/sopel-irc/sopel/security/code-scanning/tools/CodeQL/status/
Analysis produced the following metric data:
| Metric | Value |
+--------------------------------------------+--------+
| Total lines of Python code in the database | 159354 |
File counts reported by CodeQL match up exactly with my quick-and-dirty find
results:
dgw@ROGAlly:~/github/sopel-irc/sopel$ find . -type f -name '*.py' | wc -l
124
dgw@ROGAlly:~/github/sopel-irc/sopel$ find sopel/ -type f -name '*.py' | wc -l
82
Based on the above, I've checked off the "I have tested the functionality of the things this change touches" box above; seems to work exactly as I desired.
No more false security warnings in test files.
Checklist
make qa
(runsmake lint
andmake test
)