sopel-irc / sopel

:robot::speech_balloon: An easy-to-use and highly extensible IRC Bot framework. Formerly Willie.
https://sopel.chat
Other
951 stars 405 forks source link

calc: improve help output, test coverage (now 100%) #2530

Closed dgw closed 8 months ago

dgw commented 8 months ago

Error cases weren't covered by the @plugin.example tests. Fixed that.

Also declared a few more examples that should appear in the help output, to showcase more of the plugin's capabilities.

Follow-up to https://github.com/sopel-irc/sopel/pull/2503#issuecomment-1676205118.

Checklist

dgw commented 8 months ago

@Exirel @SnoopJ I had an itch to scratch in sopel/tools/calculation.py too. 😁

Edit: 09:57:57 <+xrl> dgw: it's still good for me

dgw commented 8 months ago

With apologies for the force-push, I had to rebase in order to make the wording change addressing @SnoopJ's stylistic concern over one error message. (Blame the merging of #2504.) Scout's honor that that was the only thing I changed, but this diff is small enough that you guys can definitely re-review it if you want between now and when it gets merged.