sopel-irc / sopel

:robot::speech_balloon: An easy-to-use and highly extensible IRC Bot framework. Formerly Willie.
https://sopel.chat
Other
951 stars 405 forks source link

config: space before zone in `default_time_format`'s default #2531

Closed dgw closed 8 months ago

dgw commented 8 months ago

Description

Dates like 2023-10-26 - 23:45CDT look a bit weird, and should be presented as 2023-10-26 - 23:45 CDT. (The default timezone is still UTC, don't worry.)

Checklist

Notes

While making this, I noticed that Sphinx does not output any of the attribute values. Because of that, we have the same default value defined in three different places. The header line for each attribute ideally would look like a module-level constant, e.g. name_of_config_attribute = ListAttribute('name_of_config_attribute', default=['list', 'of', 'defaults']) (and ListAttribute there would link to the type, of course). It'd save us having to duplicate default values in docstrings, at least.

This patch can't do anything about it, and I couldn't figure out in half an hour of research how to change the docs so Sphinx would do it—but now I'm annoyed, so I wanted to pass that along to everyone else. 🤪

dgw commented 8 months ago

Just forcing the head SHA to change so CI will rebuild with the new Python 3.12 job. No changes!