sopel-irc / sopel

:robot::speech_balloon: An easy-to-use and highly extensible IRC Bot framework. Formerly Willie.
https://sopel.chat
Other
949 stars 403 forks source link

plugin: type-hint `priority` argument as `Literal[]` #2555

Closed dgw closed 10 months ago

dgw commented 10 months ago

Description

This will flag any use of unrecognized values for the callable priority. It makes a good intermediate step between the current free-form str accepted and probably turning it into an Enum later.

Checklist

dgw commented 10 months ago

@SnoopJ you can look at the revised docstring if/when you like. I'll go try to finish that Enum issue I started before our big conversation on IRC about other PRs started. 😁

dgw commented 10 months ago

OK, amended. You can do that final review you self-requested at your leisure, @Exirel 😃

dgw commented 10 months ago

Oh well. I guess this is a fight I can't win. I don't care anymore. Go with it.

If this is about the quotes you added a line note to, that was an error in my rebase. Should be fixed. 😅