sopel-irc / sopel

:robot::speech_balloon: An easy-to-use and highly extensible IRC Bot framework. Formerly Willie.
https://sopel.chat
Other
951 stars 405 forks source link

find: double-backslash support + basic tests #2589

Open dgw opened 5 months ago

dgw commented 5 months ago

Description

Allowing \| or \/ is all well and good, but if one can't escape the escape character, things get very confusing! So let's make it possible to escape \ itself as \\.

With the test scaffolding now written (OK, much of it stolen from the preexisting test/builtins/test_builtins_isup.py), it'll be easier to add more cases (edge or otherwise) as we think of them.

Checklist

Notes

Early 8.0.x bugfix candidate, unless someone else feels strongly about including it in 8.0.0. Feels late in the game to add One More Thing into that milestone…