Both actions/checkout and actions/setup-python were using deprecated Node runtimes and generating warnings in our CI logs. Oh, and they'd also eventually stop working entirely when the deprecated runtime is removed. That's probably the best reason to update them.
I also discovered that there is no v1 tag for pypa/gh-action-pypi-publish, so our existing pypi.yml workflow from #2328 wouldn't ever work. Because tags can be easily changed if a malicious someone gains access to the action's repository, the release action is pinned to a specific, verified, commit's SHA.
[x] I can and do license this contribution under the EFLv2
[x] No issues are reported by make qa (runs make lint and make test)
[x] I have tested the functionality of the things this change touches
This will be handled for the ci.yml workflow by PR checks, and if the checkout & setup-python actions work there we can assume the same new versions will also work in the pypi.yml workflow.
I can't really test the pypi.yml workflow but that's no change (it was already untested), and we'll have a chance to test it for real soon enough.
Both
actions/checkout
andactions/setup-python
were using deprecated Node runtimes and generating warnings in our CI logs. Oh, and they'd also eventually stop working entirely when the deprecated runtime is removed. That's probably the best reason to update them.I also discovered that there is no
v1
tag forpypa/gh-action-pypi-publish
, so our existingpypi.yml
workflow from #2328 wouldn't ever work. Because tags can be easily changed if a malicious someone gains access to the action's repository, the release action is pinned to a specific, verified, commit's SHA.Checklist
make qa
(runsmake lint
andmake test
)ci.yml
workflow by PR checks, and if the checkout & setup-python actions work there we can assume the same new versions will also work in thepypi.yml
workflow.pypi.yml
workflow but that's no change (it was already untested), and we'll have a chance to test it for real soon enough.