Closed dgw closed 8 months ago
Refactored to use subcommands. I kind of like this style, actually. The .help
situation is a bit messy, though the details of that would be a discussion for the sopel-help
issue tracker.
Last night, @half-duplex said in our IRC: "reading only the strings and decorators in 2601: lgtm" — and that puts to rest the earlier discussion about .cleartmask
vs. .tmask clear
or other single-command structure. Shipping… :shipit:
Description
.tmask get
shows the current topic mask.tmask
without arguments assumes theget
subcommand.tmask set
now sets the topic mask, and provides a usage hint if called without further arguments.tmask clear
is added to explicitly clear the topic maskIn combination, the above should be sufficient to resolve #2596.
Checklist
make qa
(runsmake lint
andmake test
)Notes
If no one minds adding this to 8.0.0 while the release notes are still under peer review, I'm happy to get it shipped sooner.
(Because it's modifying command behavior, if we don't ship this patch in 8.0.0, I believe the semver-appropriate thing to do would be to ship the first commit in 8.0.1 and hold the second for 8.1.0.)