sopel-irc / sopel

:robot::speech_balloon: An easy-to-use and highly extensible IRC Bot framework. Formerly Willie.
https://sopel.chat
Other
948 stars 402 forks source link

adminchannel: rework topic-mask commands #2601

Closed dgw closed 8 months ago

dgw commented 8 months ago

Description

In combination, the above should be sufficient to resolve #2596.

Checklist

Notes

If no one minds adding this to 8.0.0 while the release notes are still under peer review, I'm happy to get it shipped sooner.

(Because it's modifying command behavior, if we don't ship this patch in 8.0.0, I believe the semver-appropriate thing to do would be to ship the first commit in 8.0.1 and hold the second for 8.1.0.)

dgw commented 8 months ago

Refactored to use subcommands. I kind of like this style, actually. The .help situation is a bit messy, though the details of that would be a discussion for the sopel-help issue tracker.

dgw commented 8 months ago

Last night, @half-duplex said in our IRC: "reading only the strings and decorators in 2601: lgtm" — and that puts to rest the earlier discussion about .cleartmask vs. .tmask clear or other single-command structure. Shipping… :shipit: