search

sopel-irc / sopel

:robot::speech_balloon: An easy-to-use and highly extensible IRC Bot framework. Formerly Willie.
https://sopel.chat
Other
951 stars 405 forks source link

Final 8.0 release prep #2606

Closed dgw closed 1 month ago

dgw commented 2 months ago

Description

My own branch protection settings won't let me commit a quick fix directly to master, so I guess I'll open a catch-all PR for this and any other stuff that was forgotten as part of #2600.

Checklist

SnoopJ commented 2 months ago

Not sure if this is a draft because you intend to add other things, or in case we spot something that needs adding. Either way, changes in it as of now LGTM.

dgw commented 2 months ago

It is a draft for both reasons, until the website stuff is done. Then I'll have to version-bump as part of the PR (because of those branch protection rules already mentioned). 😁

dgw commented 1 month ago

I uploaded a build of 3261d9c714fdc05ea373cc71842eb70e2f3cbb6b to https://test.pypi.org/project/sopel/8.0.0/ and everything seems to work.

Speaking of 3261d9c714fdc05ea373cc71842eb70e2f3cbb6b, when I examine (Test)PyPI's JSON API output, I can see that sopel-pypi will show the whole author list ("dgw, Florian Strzelecki, Sean B. Palmer, [etc.]"). Previous releases have only listed me as the author, and we are correcting that in the 8.x series. (Let's think of this as an opportunity to find sopel-pypi output improvements.)

The whole list is arguably still better than "(unknown name)", which is what it does for projects with both a name and email, like many of the plugins I/we have switched over to pyproject.toml metadata. There seems to be an unsolved issue in Python's ecosystem relating to pyproject.toml / PEP 621 metadata and non-empty email; see pypi/warehouse#9400 (and also pypi/warehouse#14813, a related but distinct issue with specifying email for some-but-not-all authors or maintainers).

dgw commented 1 month ago

I used the test index to install Sopel 8 and it installed successfully, without any problem for the help plugin.

Is this a reference to sopel-irc/sopel-help#11? I'm sure it doesn't affect all (or even most) Python environments; how common is it not to have setuptools installed at all? 😂 But that's also an issue for sopel-help to solve if necessary, and definitely shouldn't be a blocker for the main bot itself. That was the whole point of starting to extract nonessential plugins from core 😁

Exirel commented 1 month ago

Not even a ref to that, I just made sure that the install worked as intended because sopel-help must not break Sopel's install.