search

sopel / botocross

A Python package for operating cross region AWS resources
Other
4 stars 4 forks source link

Fix Pylint violations #37

Closed sopel closed 11 years ago

sopel commented 11 years ago

This fixes almost all violations but C0103 ('Invalid name ...') and C0111 ('Missing docstring ...'), which require or are related to pending refactorings anyway, thus will be ignored for the time being (skimming the resulting Pylint report for new issues is fairly easy now at least).

mrdavidlaing commented 11 years ago

Silly question, but where can I see the pylint report?

sopel commented 11 years ago

It's logged to stdout on execution of pylint botocross, thus is usually visible at the end of the Jenkins Console output, but ideally transformed to the way more instructive Violations Report, where you can drill down into violating files.

For the task at hand I simply run it locally though and skim table 'Messages' (interestingly the Jenkins slave reports a few more than my local environment, guess I'm not completely virtualized yet locally).

mrdavidlaing commented 11 years ago

Aha - I didn't realise the build was on Jenkins - I followed the build status logo on the README which goes to TravisCI...

I'll submit a PR to correct that.

On 15 April 2013 19:48, Steffen Opel notifications@github.com wrote:

It's logged to stdout on execution of pylint botocross, thus is usually visible at the end of the Jenkins Console outputhttp://ci.labs.cityindex.com:8080/job/botocross/36/console, but ideally transformed to the way more instructive Violations Reporthttp://ci.labs.cityindex.com:8080/job/botocross/36/violations/?, where you can drill down into violating files.

For the task at hand I simply run it locally though and skim table 'Messages' (interestingly the Jenkins slave reports a few more than my local environment, guess I'm not completely virtualized yet locally).

— Reply to this email directly or view it on GitHubhttps://github.com/sopel/botocross/pull/37#issuecomment-16400396 .

David Laing Open source @ City Index - github.com/cityindex http://davidlaing.com Twitter: @davidlaing