search

sopetrichor / react-photo-collage

MIT License
27 stars 18 forks source link

Collage does not render correctly if the layout prop has more rows that columns; #31

Closed jeffreystorer closed 2 years ago

jeffreystorer commented 2 years ago

I tried to create a collage with layout = [4,3] and found that the image height was changed from my input of 668 px to 200 px. This happens whenever there are more rows that columns.

jeffreystorer commented 2 years ago

Actually, on inspecting the code, I find that this is deliberate. Why?

jeffreystorer commented 2 years ago

Just figured it out. My bad. Sorry.